feat(logger): log uncaught exceptions via system's exception hook #1727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1636
Summary
Changes
This PR introduces a new constructor flag in Logger,
log_uncaught_exceptions, to add a custom exception hook to log any uncaught exception using customer's Logger.User experience
Leads to
ValueErroruncaught exception being logged with Logger.{ "level": "ERROR", "location": "log_uncaught_exception_hook:757", "message": "Uncaught exception", "timestamp": "2022-11-16 11:58:39,819+0100", "service": "sample", "exception": "Traceback (most recent call last):\n File \"/Users/lessa/DEV/aws-lambda-powertools-python/blah.py\", line 38, in <module>\n raise ValueError(\"Catch me if you can!\")\nValueError: Catch me if you can!", "exception_name": "ValueError" }Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.